MQL4 mxing up which trade goes with which EA?

do you 2 EA's have magic numbers? if not this should solve the problem...code magic numbers into them

They do have different Magic Numbers. I guess I could test to see if that trade was opened back by asking for the trades with that magic number - as a work around. But I'd still like to learn why the heck this is going on.

Usual problem is loose coding at the point of looping through the Orders.

Lots of people forget to check Magic Number at some point, should be something liike

  void CloseAllBuyOrders(int MN)
  {
  int i, iTotalOrders;
  
  //iTotalOrders=OrdersTotal(); 
  //for (i=0; i<iTotalOrders; i++)
   
   iTotalOrders=OrdersTotal()-1; // Rosh line
  
   for (i=iTotalOrders; i>=0; i--) // Rosh line     
   
   { 
      if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
      { 
         if (OrderMagicNumber()==MN)
         { 
            if (OrderType()==OP_BUY) OrderClose(OrderTicket(),OrderLots(),Bid,5,Violet);
            if (OrderType()==OP_BUYSTOP) OrderDelete(OrderTicket());
            if (OrderType()==OP_BUYLIMIT) OrderDelete(OrderTicket());
            
         }
      }
   }
}

  void CloseAllSellOrders(int MN)
  {
  int i, iTotalOrders;
  
  // iTotalOrders=OrdersTotal(); 
  // for (i=0; i<iTotalOrders; i++)
   
   iTotalOrders=OrdersTotal()-1; // Rosh line
  
   for (i=iTotalOrders; i>=0; i--) // Rosh line  
   { 
      if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
      { 
         if (OrderMagicNumber()==MN)
         { 
            if (OrderType()==OP_SELL) OrderClose(OrderTicket(),OrderLots(),Ask,5,Violet);
            if (OrderType()==OP_SELLSTOP) OrderDelete(OrderTicket());
            if (OrderType()==OP_SELLLIMIT) OrderDelete(OrderTicket());
         }
      }
   }
}

Good Luck

-BB-

In case it helps, I've seen something similar but not quite the same... Under heavy load such as hundreds of orders per hour I've repeatedly (and repeatably) had MetaTrader mix up the orders from different EAs running on different charts. For example, an EA running on a EURUSD chart places an order, and MetaTrader instead creates the order on a different symbol entirely (e.g. USDCHF). Not got the log files to hand any more, but they're absolutely categorical in showing a problem external to the EA. A typical entry would go like this:

06:56:33 MyEAWhatever SELL EURUSD,H1: open #64452298 sell 0.16 USDCHF at 1.3483 sl: 1.3979 tp: 1.3460 ok

I've not had a mix-up of buys and sells, but it sounds related. Both your example and my example could be a broker problem rather than a MetaTrader problem, but it's the sort of thing you tend to get in an application if your multi-threading isn't absolutely watertight.

I managed to fix my problem by implementing the recommendation at https://www.mql5.com/en/articles/1412 - the bit in sections 5 and 6. This has completely solved things for me, albeit at the cost of resorting to what's effectively co-operative multi-tasking, only allowing one EA to run at once.